ci: Make version bumping script more robust#2689
Merged
achals merged 4 commits intofeast-dev:masterfrom May 16, 2022
Merged
Conversation
Signed-off-by: Achal Shah <[email protected]>
kevjumba
reviewed
May 13, 2022
| raise SystemExit(f"Could not find {VERSIONS_TO_BUMP} versions of {current_version} in {path_to_file_list}") | ||
|
|
||
| print(f"Found {versions_in_files} occurrences of {current_version} in files to bump {path_to_file_list}") | ||
| # The current version should be 0.18.0 or 0.19.0 or 0.20.0 etc |
Collaborator
There was a problem hiding this comment.
Don't think we need 0.18.0 or 0.19.0 right? Also after version bump we're at 0.21?
Member
Author
There was a problem hiding this comment.
Just as an example, but I'll update.
kevjumba
reviewed
May 13, 2022
| with open(repo_root.joinpath(file_path), "r") as f: | ||
| file_contents = f.readlines() | ||
| for line in lines: | ||
| assert current_version in file_contents[int(line) - 1], f"File {file_path} line {line} didn't containe " \ |
Codecov Report
@@ Coverage Diff @@
## master #2689 +/- ##
===========================================
- Coverage 80.98% 58.53% -22.46%
===========================================
Files 166 166
Lines 13888 13832 -56
===========================================
- Hits 11247 8096 -3151
- Misses 2641 5736 +3095
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adchia
pushed a commit
that referenced
this pull request
May 16, 2022
* ci: Make version bumping script more robust Signed-off-by: Achal Shah <[email protected]> * bump dockerfiles too Signed-off-by: Achal Shah <[email protected]> * fix build-docker-image Signed-off-by: Achal Shah <[email protected]> * use buildx instead of build in makefile Signed-off-by: Achal Shah <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah [email protected]
Running locally is smooth:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #