Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@achals
Copy link
Member

@achals achals commented May 16, 2022

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Achal Shah <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #2705 (358d080) into master (2d56963) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   80.95%   80.80%   -0.16%     
==========================================
  Files         166      166              
  Lines       13888    13918      +30     
==========================================
+ Hits        11243    11246       +3     
- Misses       2645     2672      +27     
Flag Coverage Δ
integrationtests 71.48% <ø> (-0.25%) ⬇️
unittests 58.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/unit/test_feature_views.py 67.64% <0.00%> (-32.36%) ⬇️
sdk/python/feast/stream_feature_view.py 77.27% <0.00%> (-22.73%) ⬇️
sdk/python/feast/ui_server.py 20.68% <0.00%> (-2.72%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d56963...358d080. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented May 16, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 095dfd6 into feast-dev:master May 16, 2022
@achals achals deleted the achal/fix-other-builds branch May 16, 2022 20:54
adchia pushed a commit that referenced this pull request May 16, 2022
* ci: Use buildx for docker builds in remaining places as well

Signed-off-by: Achal Shah <[email protected]>

* fix oops

Signed-off-by: Achal Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants