fix: Change online UI schema field to be optional#2766
Merged
adchia merged 1 commit intofeast-dev:masterfrom Jun 8, 2022
Merged
fix: Change online UI schema field to be optional#2766adchia merged 1 commit intofeast-dev:masterfrom
adchia merged 1 commit intofeast-dev:masterfrom
Conversation
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (feast-dev#2719). Signed-off-by: Dirk Van Bruggen <[email protected]>
achals
approved these changes
Jun 7, 2022
Member
|
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 80.56% 80.50% -0.07%
==========================================
Files 173 173
Lines 15093 15093
==========================================
- Hits 12160 12150 -10
- Misses 2933 2943 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia, dvanbrug The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adchia
pushed a commit
that referenced
this pull request
Jun 13, 2022
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (#2719). Signed-off-by: Dirk Van Bruggen <[email protected]>
adchia
pushed a commit
that referenced
this pull request
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change the
onlinefield in feastFeatureViews schema to be optional.This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the
onlinetag.
Which issue(s) this PR fixes:
Fixes #2719