Codestin Search App

astronautas · 2025-12-22T10:32:50Z

What this PR does / why we need it:

We noticed that for some of our larger get_historical_features jobs, we started getting:

[2025-12-19, 14:16:36 UTC] {pod_manager.py:454} INFO - [base] OperationalError: Error
[2025-12-19, 14:16:36 UTC] {pod_manager.py:454} INFO - [base] HTTPConnectionPool(host='cluster-clickhouse-ml-main.ml.svc.cluster.local',
[2025-12-19, 14:16:36 UTC] {pod_manager.py:454} INFO - [base] port=8123): Read timed out. (read timeout=300) executing HTTP request attempt 1

in essence, we need to be able to control some of the client-side timeouts within the clickhouse client used by the feature store. PR introduces such functionality.

Which issue(s) this PR fixes:

(inline issue within this PR)

astronautas · 2025-12-22T10:34:17Z

@franciscojavierarceo @ntkathole A small improvement to Clickhouse offline store.

sdk/python/feast/infra/utils/clickhouse/connection_utils.py

astronautas · 2025-12-22T11:01:22Z

I'll additionally test how this more generic additional_args field works with feature_store.yaml config 🕐 . Will let you know in this thread @ntkathole .

astronautas · 2025-12-22T11:10:50Z

@ntkathole All ready from my end!

astronautas · 2025-12-22T12:12:18Z

@ntkathole Any ideas?

Run make test-python-integration
python -m pytest --tb=short -v -n 8 --integration --color=yes --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
	-k "(not snowflake or not test_historical_features_main)" \
	-m "not rbac_remote_integration_test" \
	--log-cli-level=INFO -s \
	sdk/python/tests
/opt/hostedtoolcache/Python/3.11.14/x64/bin/python: No module named pytest
make: *** [Makefile:157: test-python-integration] Error 1
Error: Process completed with exit code 2.

can we retry? Unrelated to PR, it seems :/ Caching?

ntkathole · 2025-12-22T12:19:37Z

It seems related to aws creds, looking
Error: The security token included in the request is invalid.

Signed-off-by: lukas.valatka <[email protected]>

ntkathole

looks good

… offline store (feast-dev#5792) * add changes + fix linting issues Signed-off-by: lukas.valatka <[email protected]> * generalize based on pr suggestion Signed-off-by: lukas.valatka <[email protected]> * add test verifying config parsing Signed-off-by: lukas.valatka <[email protected]> * rework test into integration, since CH instance is needed Signed-off-by: lukas.valatka <[email protected]> --------- Signed-off-by: lukas.valatka <[email protected]> Signed-off-by: Anthonette Adanyin <[email protected]>

# [0.59.0](v0.58.0...v0.59.0) (2026-01-16) ### Bug Fixes * Add get_table_query_string_with_alias() for PostgreSQL subquery aliasing ([#5811](#5811)) ([11122ce](11122ce)) * Add hybrid online store to ONLINE_STORE_CLASS_FOR_TYPE mapping ([#5810](#5810)) ([678589b](678589b)) * Add possibility to overwrite send_receive_timeout for clickhouse offline store ([#5792](#5792)) ([59dbb33](59dbb33)) * Denial by default to all resources when no permissions set ([#5663](#5663)) ([1524f1c](1524f1c)) * Make operator include full OIDC secret in repo config ([#5676](#5676)) ([#5809](#5809)) ([a536bc2](a536bc2)) * Populate Postgres `registry.path` during `feast init` ([#5785](#5785)) ([f293ae8](f293ae8)) * **redis:** Preserve millisecond timestamp precision for Redis online store ([#5807](#5807)) ([9e3f213](9e3f213)) * Search API to return all matching tags in matched_tags field ([#5843](#5843)) ([de37f66](de37f66)) * Spark Materialization Engine Cannot Infer Schema ([#5806](#5806)) ([58d0325](58d0325)), closes [#5594](#5594) [#5594](#5594) * Support arro3 table schema with newer deltalake packages ([#5799](#5799)) ([103c5e9](103c5e9)) * Timestamp formatting and lakehouse-type connector for trino_offline_store. ([#5846](#5846)) ([c2ea7e9](c2ea7e9)) * Update model_validator to use instance method signature (Pydantic v2.12 deprecation) ([#5825](#5825)) ([3c10b6e](3c10b6e)) ### Features * Add dbt integration for importing models as FeatureViews ([#5827](#5827)) ([b997361](b997361)), closes [#3335](#3335) [#3335](#3335) [#3335](#3335) * Add GCS registry store in Go feature server ([#5818](#5818)) ([1dc2be5](1dc2be5)) * Add progress bar to CLI from feast apply ([#5867](#5867)) ([ab3562b](ab3562b)) * Add RBAC blog post to website ([#5861](#5861)) ([b1844a3](b1844a3)) * Add skip_feature_view_validation parameter to FeatureStore.apply() and plan() ([#5859](#5859)) ([5482a0e](5482a0e)) * Added batching to feature server /push to offline store ([#5683](#5683)) ([#5729](#5729)) ([ce35ce6](ce35ce6)) * Enable static artifacts for feature server that can be used in Feature Transformations ([#5787](#5787)) ([edefc3f](edefc3f)) * Improve lambda materialization engine ([#5829](#5829)) ([f6116f9](f6116f9)) * Offline Store historical features retrieval based on datetime range in Ray ([#5738](#5738)) ([e484c12](e484c12)) * Read, Save docs and chat fixes ([#5865](#5865)) ([2081b55](2081b55)) * Resolve pyarrow >21 installation with ibis-framework ([#5847](#5847)) ([8b9bb50](8b9bb50)) * Support staging for spark materialization ([#5671](#5671)) ([#5797](#5797)) ([5b787af](5b787af))

# [0.59.0](feast-dev/feast@v0.58.0...v0.59.0) (2026-01-16) ### Bug Fixes * Add get_table_query_string_with_alias() for PostgreSQL subquery aliasing ([feast-dev#5811](feast-dev#5811)) ([11122ce](feast-dev@11122ce)) * Add hybrid online store to ONLINE_STORE_CLASS_FOR_TYPE mapping ([feast-dev#5810](feast-dev#5810)) ([678589b](feast-dev@678589b)) * Add possibility to overwrite send_receive_timeout for clickhouse offline store ([feast-dev#5792](feast-dev#5792)) ([59dbb33](feast-dev@59dbb33)) * Denial by default to all resources when no permissions set ([feast-dev#5663](feast-dev#5663)) ([1524f1c](feast-dev@1524f1c)) * Make operator include full OIDC secret in repo config ([feast-dev#5676](feast-dev#5676)) ([feast-dev#5809](feast-dev#5809)) ([a536bc2](feast-dev@a536bc2)) * Populate Postgres `registry.path` during `feast init` ([feast-dev#5785](feast-dev#5785)) ([f293ae8](feast-dev@f293ae8)) * **redis:** Preserve millisecond timestamp precision for Redis online store ([feast-dev#5807](feast-dev#5807)) ([9e3f213](feast-dev@9e3f213)) * Search API to return all matching tags in matched_tags field ([feast-dev#5843](feast-dev#5843)) ([de37f66](feast-dev@de37f66)) * Spark Materialization Engine Cannot Infer Schema ([feast-dev#5806](feast-dev#5806)) ([58d0325](feast-dev@58d0325)), closes [feast-dev#5594](feast-dev#5594) [feast-dev#5594](feast-dev#5594) * Support arro3 table schema with newer deltalake packages ([feast-dev#5799](feast-dev#5799)) ([103c5e9](feast-dev@103c5e9)) * Timestamp formatting and lakehouse-type connector for trino_offline_store. ([feast-dev#5846](feast-dev#5846)) ([c2ea7e9](feast-dev@c2ea7e9)) * Update model_validator to use instance method signature (Pydantic v2.12 deprecation) ([feast-dev#5825](feast-dev#5825)) ([3c10b6e](feast-dev@3c10b6e)) ### Features * Add dbt integration for importing models as FeatureViews ([feast-dev#5827](feast-dev#5827)) ([b997361](feast-dev@b997361)), closes [feast-dev#3335](feast-dev#3335) [feast-dev#3335](feast-dev#3335) [feast-dev#3335](feast-dev#3335) * Add GCS registry store in Go feature server ([feast-dev#5818](feast-dev#5818)) ([1dc2be5](feast-dev@1dc2be5)) * Add progress bar to CLI from feast apply ([feast-dev#5867](feast-dev#5867)) ([ab3562b](feast-dev@ab3562b)) * Add RBAC blog post to website ([feast-dev#5861](feast-dev#5861)) ([b1844a3](feast-dev@b1844a3)) * Add skip_feature_view_validation parameter to FeatureStore.apply() and plan() ([feast-dev#5859](feast-dev#5859)) ([5482a0e](feast-dev@5482a0e)) * Added batching to feature server /push to offline store ([feast-dev#5683](feast-dev#5683)) ([feast-dev#5729](feast-dev#5729)) ([ce35ce6](feast-dev@ce35ce6)) * Enable static artifacts for feature server that can be used in Feature Transformations ([feast-dev#5787](feast-dev#5787)) ([edefc3f](feast-dev@edefc3f)) * Improve lambda materialization engine ([feast-dev#5829](feast-dev#5829)) ([f6116f9](feast-dev@f6116f9)) * Offline Store historical features retrieval based on datetime range in Ray ([feast-dev#5738](feast-dev#5738)) ([e484c12](feast-dev@e484c12)) * Read, Save docs and chat fixes ([feast-dev#5865](feast-dev#5865)) ([2081b55](feast-dev@2081b55)) * Resolve pyarrow >21 installation with ibis-framework ([feast-dev#5847](feast-dev#5847)) ([8b9bb50](feast-dev@8b9bb50)) * Support staging for spark materialization ([feast-dev#5671](feast-dev#5671)) ([feast-dev#5797](feast-dev#5797)) ([5b787af](feast-dev@5b787af)) Signed-off-by: Kyle DePasquale <[email protected]>

astronautas requested a review from a team as a code owner December 22, 2025 10:32

astronautas force-pushed the fix/control-clickhouse-offline-store-client-timeouts branch 2 times, most recently from a9c9902 to 508bf0f Compare December 22, 2025 10:44

ntkathole reviewed Dec 22, 2025

View reviewed changes

sdk/python/feast/infra/utils/clickhouse/connection_utils.py Outdated Show resolved Hide resolved

ntkathole added the ok-to-test label Dec 22, 2025

astronautas added 4 commits December 23, 2025 12:56

add changes + fix linting issues

2f5a1c1

Signed-off-by: lukas.valatka <[email protected]>

generalize based on pr suggestion

24f6f40

Signed-off-by: lukas.valatka <[email protected]>

add test verifying config parsing

a05c6ab

Signed-off-by: lukas.valatka <[email protected]>

rework test into integration, since CH instance is needed

a3b9977

Signed-off-by: lukas.valatka <[email protected]>

ntkathole force-pushed the fix/control-clickhouse-offline-store-client-timeouts branch from 15c6d7a to a3b9977 Compare December 23, 2025 07:26

ntkathole approved these changes Dec 23, 2025

View reviewed changes

ntkathole merged commit 59dbb33 into feast-dev:master Dec 23, 2025
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add possibility to overwrite send_receive_timeout for clickhouse offline store#5792

fix: Add possibility to overwrite send_receive_timeout for clickhouse offline store#5792
ntkathole merged 4 commits intofeast-dev:masterfrom
astronautas:fix/control-clickhouse-offline-store-client-timeouts

astronautas commented Dec 22, 2025

Uh oh!

astronautas commented Dec 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

astronautas commented Dec 22, 2025 •

edited

Loading

Uh oh!

astronautas commented Dec 22, 2025 •

edited

Loading

Uh oh!

astronautas commented Dec 22, 2025 •

edited

Loading

Uh oh!

ntkathole commented Dec 22, 2025

Uh oh!

ntkathole left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

astronautas commented Dec 22, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:

Uh oh!

astronautas commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

astronautas commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

astronautas commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

astronautas commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ntkathole commented Dec 22, 2025

Uh oh!

ntkathole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

astronautas commented Dec 22, 2025 •

edited

Loading

astronautas commented Dec 22, 2025 •

edited

Loading

astronautas commented Dec 22, 2025 •

edited

Loading

astronautas commented Dec 22, 2025 •

edited

Loading