Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Added online server worker config support in operator #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
franciscojavierarceo merged 1 commit into from
Jan 31, 2026
Merged

feat: Added online server worker config support in operator #5926

franciscojavierarceo merged 1 commit into from
Jan 31, 2026
+2,594 −1

Conversation

@ntkathole
Copy link
Member

@ntkathole ntkathole commented Jan 30, 2026 •
edited by devin-ai-integration bot
Loading

What this PR does / why we need it:

This PR adds support for configuring the new serving options introduced in PR #5881 via the Feast Operator. These options allow users to optimize the online store (feature server) for production deployments.

Example Usage:

apiVersion: feast.dev/v1
kind: FeatureStore
metadata:
  name: my-feast
spec:
  feastProject: my_project
  services:
    onlineStore:
      server:
        workerConfigs:
          workers: -1              # Auto-calculate based on CPU cores
          workerConnections: 2000
          maxRequests: 1000
          maxRequestsJitter: 50
          keepAliveTimeout: 30
          registryTTLSeconds: 60
Open with Devin

@ntkathole ntkathole self-assigned this Jan 31, 2026
@ntkathole ntkathole force-pushed the operator_worker_configs branch from 659ce3a to 9e46dcf Compare January 31, 2026 05:13
@ntkathole ntkathole marked this pull request as ready for review January 31, 2026 07:13
@ntkathole ntkathole requested a review from a team as a code owner January 31, 2026 07:13
devin-ai-integration[bot]
devin-ai-integration bot reviewed Jan 31, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

Open in Devin Review

franciscojavierarceo
franciscojavierarceo approved these changes Jan 31, 2026
View reviewed changes
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit please but otherwise lgtm

Makefile
VERSION=$(VERSION) \
$(MAKE) docker-build

build-feast-operator-docker-on-mac: ## Build Feast Operator Docker image on Mac
Copy link
Member

@franciscojavierarceo franciscojavierarceo Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just Donna if statement for the OS?

Copy link
Member Author

@ntkathole ntkathole Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding OS auto-detection would force --platform linux/amd64 on all Mac builds, breaking users who intentionally want native ARM images for local development/testing. Keeping separate _on_mac targets gives explicit control: native arch by default, cross-platform when explicitly requested.

Alternatively, we could use an environment variable (e.g., DOCKER_PLATFORM) or configure Docker's default platform at the system level, but these add extra configuration overhead for contributors to remember.

Copy link
Member

@franciscojavierarceo franciscojavierarceo Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to remember to use this command though so still same problem but okay

@franciscojavierarceo franciscojavierarceo merged commit 193c72a into feast-dev:master Jan 31, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntkathole @franciscojavierarceo