obejectId query cmd update#360
Merged
xiaoyongzhu merged 2 commits intofeathr-ai:mainfrom Jun 14, 2022
Merged
Conversation
jainr
approved these changes
Jun 14, 2022
Collaborator
jainr
left a comment
There was a problem hiding this comment.
Thanks for making this fix with objectId, I also made the fix for this in my ARM template PR but in only covers the template.
I am not sure if you reformatted but there seems a big delta in ARM template, was any other thing changed except objectId?
xiaoyongzhu
approved these changes
Jun 14, 2022
Collaborator
|
I also agree with consolidating this in a single place, please share your ideas. |
bozhonghu
pushed a commit
that referenced
this pull request
Jun 15, 2022
* main: Fixing purview test issues and improve performance (#350) [feathr] Add product_recommendation advanced sample (#348) obejectId query cmd update (#360) add license, release, docs, python api ref badges with shields img (#357) quick fix the 404 not found in read me link (#355) Python SQL Registry (#311) enable JWT token param in frontend API calls (#337) Optimize environment variable behavior (#333) Adding better warning message to let user know that config file is missing and they need to set env parameters. (#347) Feature Monitoring (#330) Windoze/211 maven submission (#334) Windoze/211 maven submission (#334) Windoze/211 maven submission (#334) Fix Synapse quickstart link (#346) Show feature details when click feature in lineage graph (#339) Update pull_request_push_test.yml Update UI README for how to create overrides for local development (#335) Update databricks quick start experience (#217)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If user is using Azure CLI Version <= 2.36, then the original objectId works.
However, the cloud shell always run the latest version. Thus, I just simply update command in each occurrence.
(Please check the issue link to find more backgrounds about Azure CLI upgrade)
Also, I'd like to raise a potential risk of doc maintenance: this command exists in 8 files and 5 of them are notebook / markdown guide. Will it be better to abstract the content into a single "How-to-provision-azure-resource" and link to it?