Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix graph edge errors when calling SQL APIs #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blrchen merged 4 commits into from
Aug 23, 2022
Merged

Fix graph edge errors when calling SQL APIs #593

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce06653
Fix graph edge errors when calling sql APIs
Aug 19, 2022
72104c6
Merge branch 'main' into enya/sql-graph
Aug 23, 2022
493c6f0
minor fix
Aug 23, 2022
06ddafb
minor change
Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions registry/sql-registry/registry/db_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ def _fill_entity(self, e: Entity) -> Entity:
return e

def _get_edges(self, ids: list[UUID], types: list[RelationshipType] = []) -> list[Edge]:
if not ids or not types:
if not ids:
return []
sql = fr"""select edge_id, from_id, to_id, conn_type from edges
where from_id in %(ids)s
Expand All @@ -415,9 +415,10 @@ def _get_edges(self, ids: list[UUID], types: list[RelationshipType] = []) -> lis
where conn_type in %(types)s
and from_id in %(ids)s
and to_id in %(ids)s"""

rows = self.conn.query(sql, {
"ids": tuple([str(id) for id in ids]),
"types": tuple([str(t) for t in types]),
"types": tuple([t.name for t in types]),
})
return list([_to_type(row, Edge) for row in rows])

Expand Down