Support 'hourly' resolution for 'timePartitionPattern' #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 1, 2022 16:34
This reverts commit 155212a.
This reverts commit 585e2ae.
feathr-ai#815)" This reverts commit 6b5cd00.
…d feature (feathr-ai#815)"" This reverts commit 05fa959.
feathr-ai#814)"" This reverts commit 7f68162.
xiaoyongzhu
reviewed
Nov 16, 2022
| 2020, 5, 20), end=datetime(2020, 5, 20), step=timedelta(days=1)) | ||
|
|
||
| if client_producer.spark_runtime == 'databricks': | ||
| output_path = 'dbfs:/timePartitionPattern_hourly_sample' |
Member
There was a problem hiding this comment.
better to add some time signature in the output path so each job's output can be unique
Collaborator
Author
There was a problem hiding this comment.
this is used as data source not the output we want to check so maybe we don't need to take extra space to save it
Collaborator
Author
|
Merged this change into the PR: #858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How was this PR tested?
Does this PR introduce any user-facing changes?