Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Insert test coverage check for python client into github pipeline #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enya-yx merged 3 commits into from
Nov 21, 2022
Merged

Insert test coverage check for python client into github pipeline #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feca391
Insert test coverage check for python client into github pipeline
Nov 14, 2022
ea78d17
quick change
Nov 16, 2022
e1e5d97
quick change
Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/.coveragerc_db
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[run]
omit = feathr_project/feathr/registry/_feature_registry_purview.py
feathr_project/feathr/spark_provider/_synapse_submission.py
feathr_project/feathr/spark_provider/_localspark_submission.py
[report]
exclude_lines =
pragma: no cover
@abstract
8 changes: 8 additions & 0 deletions .github/workflows/.coveragerc_local
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[run]
omit = feathr_project/feathr/registry/_feature_registry_purview.py
feathr_project/feathr/spark_provider/_databricks_submission.py
feathr_project/feathr/spark_provider/_synapse_submission.py
[report]
exclude_lines =
pragma: no cover
@abstract
8 changes: 8 additions & 0 deletions .github/workflows/.coveragerc_sy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[run]
omit = feathr_project/feathr/registry/_feature_registry_purview.py
feathr_project/feathr/spark_provider/_databricks_submission.py
feathr_project/feathr/spark_provider/_localspark_submission.py
[report]
exclude_lines =
pragma: no cover
@abstract
7 changes: 3 additions & 4 deletions .github/workflows/pull_request_push_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ jobs:
SQL1_PASSWORD: ${{secrets.SQL1_PASSWORD}}
run: |
# run only test with databricks. run in 4 parallel jobs
pytest -n 6 feathr_project/test/

pytest -n 6 --cov-report term-missing --cov=feathr_project/feathr feathr_project/test --cov-config=.github/workflows/.coveragerc_db
azure_synapse_test:
# might be a bit duplication to setup both the azure_synapse test and databricks test, but for now we will keep those to accelerate the test speed
runs-on: ubuntu-latest
Expand Down Expand Up @@ -197,7 +196,7 @@ jobs:
run: |
# skip databricks related test as we just ran the test; also seperate databricks and synapse test to make sure there's no write conflict
# run in 4 parallel jobs to make the time shorter
pytest -n 6 feathr_project/test/
pytest -n 6 --cov-report term-missing --cov=feathr_project/feathr feathr_project/test --cov-config=.github/workflows/.coveragerc_sy

local_spark_test:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -255,7 +254,7 @@ jobs:
SQL1_PASSWORD: ${{secrets.SQL1_PASSWORD}}
run: |
# skip cloud related tests
pytest feathr_project/test/test_local_spark_e2e.py
pytest --cov-report term-missing --cov=feathr_project/feathr/spark_provider feathr_project/test/test_local_spark_e2e.py --cov-config=.github/workflows/.coveragerc_local

failure_notification:
# If any failure, warning message will be sent
Expand Down
1 change: 1 addition & 0 deletions feathr_project/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"black>=22.1.0", # formatter
"isort", # sort import statements
"pytest>=7",
"pytest-cov",
"pytest-xdist",
"pytest-mock>=3.8.1",
],
Expand Down