Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable auth if Feathr is deployed with RBAC set to off #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windoze merged 2 commits into from
Jan 5, 2023
Merged

Disable auth if Feathr is deployed with RBAC set to off #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dabc83
Disable auth if Feathr is deployed with RBAC set to off
Fendoe Dec 15, 2022
05390a2
Merge branch 'main' into feature-924
Fendoe Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 38 additions & 41 deletions ui/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import React from 'react'

import { InteractionType } from '@azure/msal-browser'
import { MsalAuthenticationTemplate, MsalProvider } from '@azure/msal-react'
import { Layout } from 'antd'
import { QueryClient, QueryClientProvider } from 'react-query'
import { BrowserRouter, Route, Routes } from 'react-router-dom'
Expand All @@ -20,54 +18,53 @@ import Projects from '@/pages/Projects'
import ResponseErrors from '@/pages/ResponseErrors'
import RoleManagement from '@/pages/RoleManagement'

import AzureMsal from './components/AzureMsal'
import Header from './components/HeaderBar/header'
import SideMenu from './components/SiderMenu/siteMenu'
import { getMsalConfig } from './utils/utils'

const queryClient = new QueryClient()

const msalClient = getMsalConfig()
const enableRBAC = window.environment?.enableRBAC
const authEnable: boolean = (enableRBAC ? enableRBAC : process.env.REACT_APP_ENABLE_RBAC) === 'true'

const App = () => {
return (
<MsalProvider instance={msalClient}>
<MsalAuthenticationTemplate interactionType={InteractionType.Redirect}>
<QueryClientProvider client={queryClient}>
<BrowserRouter>
<Layout style={{ minHeight: '100vh', position: 'relative' }}>
<SideMenu />
<Layout style={{ position: 'relative' }}>
<Header />
<Layout.Content>
<Routes>
<Route index element={<Home />} />
<Route path="/home" element={<Home />} />
<Route path="/projects" element={<Projects />} />
<Route path="/dataSources" element={<DataSources />} />
<Route path="/features" element={<Features />} />
<Route path="/new-feature" element={<NewFeature />} />
<Route
path="/projects/:project/features/:featureId"
element={<FeatureDetails />}
/>
<Route
path="/projects/:project/dataSources/:dataSourceId"
element={<DataSourceDetails />}
/>
<Route path="/projects/:project/lineage" element={<ProjectLineage />} />
<Route path="/jobs" element={<Jobs />} />
<Route path="/monitoring" element={<Monitoring />} />
<Route path="/management" element={<Management />} />
<Route path="/role-management" element={<RoleManagement />} />
<Route path="/responseErrors/:status/:detail" element={<ResponseErrors />} />
</Routes>
</Layout.Content>
</Layout>
<AzureMsal enable={authEnable}>
<QueryClientProvider client={queryClient}>
<BrowserRouter>
<Layout style={{ minHeight: '100vh', position: 'relative' }}>
<SideMenu />
<Layout style={{ position: 'relative' }}>
<Header />
<Layout.Content>
<Routes>
<Route index element={<Home />} />
<Route path="/home" element={<Home />} />
<Route path="/projects" element={<Projects />} />
<Route path="/dataSources" element={<DataSources />} />
<Route path="/features" element={<Features />} />
<Route path="/new-feature" element={<NewFeature />} />
<Route
path="/projects/:project/features/:featureId"
element={<FeatureDetails />}
/>
<Route
path="/projects/:project/dataSources/:dataSourceId"
element={<DataSourceDetails />}
/>
<Route path="/projects/:project/lineage" element={<ProjectLineage />} />
<Route path="/jobs" element={<Jobs />} />
<Route path="/monitoring" element={<Monitoring />} />
<Route path="/management" element={<Management />} />
<Route path="/role-management" element={<RoleManagement />} />
<Route path="/responseErrors/:status/:detail" element={<ResponseErrors />} />
</Routes>
</Layout.Content>
</Layout>
</BrowserRouter>
</QueryClientProvider>
</MsalAuthenticationTemplate>
</MsalProvider>
</Layout>
</BrowserRouter>
</QueryClientProvider>
</AzureMsal>
)
}

Expand Down
28 changes: 28 additions & 0 deletions ui/src/components/AzureMsal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import React, { ReactNode } from 'react'

import { InteractionType } from '@azure/msal-browser'
import { MsalAuthenticationTemplate, MsalProvider } from '@azure/msal-react'

import { getMsalConfig } from '@/utils/utils'

const msalInstance = getMsalConfig()

export interface AzureMsalProps {
children?: ReactNode
enable?: boolean
}

const AzureMsal = (props: AzureMsalProps) => {
const { children, enable } = props
return enable ? (
<MsalProvider instance={msalInstance}>
<MsalAuthenticationTemplate interactionType={InteractionType.Redirect}>
{children}
</MsalAuthenticationTemplate>
</MsalProvider>
) : (
<>{children}</>
)
}

export default AzureMsal