Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix config generation #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blrchen merged 1 commit into from
Jan 18, 2023
Merged

Fix config generation #986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions feathr_project/feathr/definition/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def to_feature_config(self) -> str:
anonymous: true
{% endif %}
}
{% if source.event_timestamp_column is defined %}
{% if source.event_timestamp_column %}
timeWindowParameters: {
timestampColumn: "{{source.event_timestamp_column}}"
timestampColumnFormat: "{{source.timestamp_format}}"
Expand Down Expand Up @@ -403,7 +403,7 @@ def to_feature_config(self) -> str:
table: "{{source.table}}"
{% endif %}
}
{% if source.event_timestamp_column is defined %}
{% if source.event_timestamp_column %}
timeWindowParameters: {
timestampColumn: "{{source.event_timestamp_column}}"
timestampColumnFormat: "{{source.timestamp_format}}"
Expand All @@ -418,11 +418,11 @@ def get_required_properties(self):
return []

def to_dict(self) -> Dict[str, str]:
ret = self.options.copy()
ret = {}
ret["type"] = "sparksql"
if self.sql:
if hasattr(self, "sql"):
ret["sql"] = self.sql
elif self.table:
elif hasattr(self, "table"):
ret["table"] = self.table
return ret

Expand Down Expand Up @@ -462,7 +462,7 @@ def to_feature_config(self) -> str:
{{option.key}}: "{{option.value}}"
{% endfor %}
}
{% if source.event_timestamp_column is defined %}
{% if source.event_timestamp_column %}
timeWindowParameters: {
timestampColumn: "{{source.event_timestamp_column}}"
timestampColumnFormat: "{{source.timestamp_format}}"
Expand Down