Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat!: nullsafety #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felangel merged 13 commits into from
Mar 2, 2021
Merged

feat!: nullsafety #84

felangel merged 13 commits into from
Mar 2, 2021

Conversation

@felangel
Copy link
Owner

@felangel felangel commented Sep 9, 2020 •
edited
Loading

Status

READY

Breaking Changes

YES

Description

  • feat!: nullsafety

Todos

  • Tests
  • Documentation
  • Examples

@felangel felangel added the enhancement New feature or request label Sep 9, 2020
@felangel felangel self-assigned this Sep 9, 2020
@felangel felangel force-pushed the null_safety branch 2 times, most recently from c542c2f to 2966ce4 Compare September 9, 2020 04:53
felangel
felangel commented Sep 9, 2020
View reviewed changes
felangel
felangel commented Sep 9, 2020
View reviewed changes
@felangel felangel force-pushed the null_safety branch 3 times, most recently from 03bb0bb to c8a4bb3 Compare September 9, 2020 04:59
kwalrath
kwalrath reviewed Sep 15, 2020
View reviewed changes
@skreborn
Copy link

skreborn commented Nov 10, 2020

Is this blocked on anything? Would be lovely if a -nullsafety pre-release could be made available to help depending packages migrate.

@felangel
Copy link
Owner Author

felangel commented Nov 19, 2020

@skreborn I plan to publish a null-safety release very shortly 👍

@felangel felangel force-pushed the null_safety branch 5 times, most recently from ce86e21 to 60409c5 Compare November 22, 2020 04:22
@felangel
Copy link
Owner Author

felangel commented Nov 22, 2020

Published v2.0.0-nullsafety.0 🎉

@felangel
Copy link
Owner Author

felangel commented Jan 6, 2021

Published v2.0.0-nullsafety.1 🎉

@Jjagg
Copy link

Jjagg commented Feb 18, 2021

Hi @felangel! If/once you're confident in the implementation here, please consider releasing this branch to stable so packages depending on this one can follow.

Blog post:
https://medium.com/dartlang/preparing-the-dart-and-flutter-ecosystem-for-null-safety-e550ce72c010

@felangel
Copy link
Owner Author

felangel commented Feb 21, 2021 •
edited
Loading

@munificent @filiph @kwalrath I'd love to release v2.0.0 but would like to close #107 first (see #108 for the changes I'm leaning toward making). If you have time can you take a look and weigh in on whether the change should be made to support legacy == overrides which use dynamic. I understand the use-case for the EquatableMixin since there may be times when developers want to use the mixin with an external object but I don't think it makes sense to apply the change to the Equatable class itself. Would love to hear your thoughts, thanks!

@felangel felangel mentioned this pull request Feb 21, 2021
Closed
3 tasks
@felangel
Copy link
Owner Author

felangel commented Feb 26, 2021

Published v2.0.0-nullsafety.4 🎉

If all goes well, I'll release v2.0.0 this weekend.

@felangel
Copy link
Owner Author

felangel commented Mar 2, 2021

Finally merging this and publishing v2.0.0 🎉

@felangel felangel merged commit d7f5053 into master Mar 2, 2021
@felangel felangel deleted the null_safety branch March 2, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@munificent munificent munificent left review comments

@filiph filiph filiph left review comments

@kwalrath kwalrath kwalrath left review comments

@lrhn lrhn lrhn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@felangel felangel

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@felangel @skreborn @Jjagg @munificent @filiph @kwalrath @lrhn @Abhishek01039