[SQL] Option to discover correlated table columns #5455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new --correlatedColumns compiler flag that performs lineage analysis to discover table columns that are directly compared in equijoin operations. The feature outputs correlated column sets in the format [Correlated:] [table0.column1, table2.column0, ...].
Changes:
- Added new
Lineagevisitor class (~846 lines) implementing dataflow lineage analysis - Added
--correlatedColumnscommand-line flag to enable the feature - Added test coverage for both inner lineage analysis and the end-to-end flag functionality
- Updated documentation to describe the new option
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
Lineage.java |
New visitor implementing lineage analysis through dataflow graph traversal and symbolic interpretation |
LineageTests.java |
New test file with unit tests for inner lineage analysis and integration test for the correlatedColumns flag |
CompilerOptions.java |
Added correlatedColumns boolean option and reorganized toString output alphabetically |
CircuitOptimizer.java |
Integrated Lineage visitor into optimization pipeline when flag is enabled |
using.md |
Added documentation for the new --correlatedColumns flag with usage examples |
MetadataTests.java |
Updated help message test to include new flag |
DBSPAssignmentExpression.java |
Added clarifying documentation comment |
ToDotNodesVisitor.java |
Refactored join operator coloring to use DBSPJoinBaseOperator check |
...ompiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/Lineage.java
Show resolved
Hide resolved
...ompiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/Lineage.java
Show resolved
Hide resolved
...ompiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/Lineage.java
Show resolved
Hide resolved
...ompiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/Lineage.java
Show resolved
Hide resolved
...ompiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/Lineage.java
Show resolved
Hide resolved
...ompiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/Lineage.java
Show resolved
Hide resolved
Signed-off-by: Mihai Budiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5441
@swanandx please try this and approve if the output is what you need.
See the file using.md for some brief documentation.