[SQLLIB] Implement abs and sign for unsigned types #5456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the abs and sign functions for unsigned integer types (u8, u16, u32, u64, u128) to fix issues #5448 and #5449.
Changes:
- Added
absimplementations for unsigned integer types that return the value unchanged (since unsigned values are always non-negative) - Added
signimplementations for all integer types (both signed and unsigned) - Added a regression test to verify the functionality
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/sqllib/src/lib.rs | Implements abs functions for unsigned types (u8-u128) and sign functions for all integer types with appropriate polymorphic function registrations |
| sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression1Tests.java | Adds test case for abs and sign functions on unsigned integers |
...er/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression1Tests.java
Show resolved
Hide resolved
rivudhk
approved these changes
Jan 18, 2026
Signed-off-by: Mihai Budiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5448
Fixes #5449