Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ryzhyk
Copy link
Contributor

@ryzhyk ryzhyk commented Jan 18, 2026

The new verbose flag can be used to log detailed progress at the INFO level for a specific connector.

Currently we only log add/delete actions in follow and cdc modes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a verbose configuration setting to the Delta Table input connector, enabling detailed logging of Delta Lake transaction log entries at the INFO level. The feature is designed to help users debug and monitor Delta Lake connector behavior, particularly in follow and CDC modes.

Changes:

  • Added a verbose field (u32) to DeltaTableReaderConfig with default value 0
  • Implemented verbose logging in process_log_entry that logs Add/Remove actions with data_change=true
  • Documentation explains the verbose levels (0=off, 1=log actions, >1=reserved)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
crates/feldera-types/src/transport/delta_table.rs Adds verbose configuration field to DeltaTableReaderConfig with documentation
crates/adapters/src/integrated/delta_table/input.rs Implements verbose logging in process_log_entry method to log filtered Delta actions

"description": "Table URI.\n\nExample: \"s3://feldera-fraud-detection-data/demographics_train\""
},
"verbose": {
"type": "integer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be unsigned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says "minimum": 0 below, I guess that's how you do unsigned in OpenAPI 🤷

@ryzhyk ryzhyk enabled auto-merge January 18, 2026 21:33
@ryzhyk ryzhyk added this pull request to the merge queue Jan 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2026
The new `verbose` flag can be used to log detailed progress at the INFO level
for a specific connector.

Currently we only log add/delete actions in follow and cdc modes.

Signed-off-by: Leonid Ryzhyk <[email protected]>
@ryzhyk ryzhyk enabled auto-merge January 18, 2026 22:50
@ryzhyk ryzhyk added this pull request to the merge queue Jan 18, 2026
Merged via the queue into main with commit abdd71b Jan 19, 2026
1 check passed
@ryzhyk ryzhyk deleted the delta-debug-log branch January 19, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants