-
Notifications
You must be signed in to change notification settings - Fork 97
[adapters] Add verbose config setting for delta.
#5459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a verbose configuration setting to the Delta Table input connector, enabling detailed logging of Delta Lake transaction log entries at the INFO level. The feature is designed to help users debug and monitor Delta Lake connector behavior, particularly in follow and CDC modes.
Changes:
- Added a
verbosefield (u32) toDeltaTableReaderConfigwith default value 0 - Implemented verbose logging in
process_log_entrythat logs Add/Remove actions withdata_change=true - Documentation explains the verbose levels (0=off, 1=log actions, >1=reserved)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/feldera-types/src/transport/delta_table.rs | Adds verbose configuration field to DeltaTableReaderConfig with documentation |
| crates/adapters/src/integrated/delta_table/input.rs | Implements verbose logging in process_log_entry method to log filtered Delta actions |
| "description": "Table URI.\n\nExample: \"s3://feldera-fraud-detection-data/demographics_train\"" | ||
| }, | ||
| "verbose": { | ||
| "type": "integer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be unsigned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says "minimum": 0 below, I guess that's how you do unsigned in OpenAPI 🤷
The new `verbose` flag can be used to log detailed progress at the INFO level for a specific connector. Currently we only log add/delete actions in follow and cdc modes. Signed-off-by: Leonid Ryzhyk <[email protected]>
2e957f3 to
875ff08
Compare
The new
verboseflag can be used to log detailed progress at the INFO level for a specific connector.Currently we only log add/delete actions in follow and cdc modes.