[adapters] Fix accounting of queued batches with transaction. #5466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change introduced a corner case where an empty batch was pushed to the queue, but the queued batch counter was not updated, leading to an underflow when dequeing the batch. Signed-off-by: Leonid Ryzhyk <[email protected]>
mihaibudiu
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where an empty batch was pushed to an endpoint queue without updating the queued batch counter, which could cause an underflow when dequeuing. The fix adds a call to enqueue_batch with a size of 0 to properly track the queued batch.
Changes:
- Added missing
enqueue_batchcall for empty batches created during transactions to prevent counter underflow
gz
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5464
A recent change introduced a corner case where an empty batch was pushed to the queue, but the queued batch counter was not updated, leading to an underflow when dequeuing the batch.