[SQL] Advance Calcite version; convert all input types to the result type in an INTERSECT operation #5490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
…type in an INTERSECT operation Signed-off-by: Mihai Budiu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Calcite version and fixes type conversion issues in INTERSECT operations by ensuring all input types are properly converted to the result type.
Changes:
- Advances the Calcite commit to version
ea08b43db6bc83ea76678bd77873e110083c0edc - Refactors INTERSECT operation handling to convert input types to the result type during indexing
- Adds regression tests for issues #5425 (DESCRIPTOR with array indexing) and #5484 (INTERSECT with user-defined types)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| calcite_version.env | Updates the Calcite commit hash to the next version |
| Regression2Tests.java | Adds two new regression tests for the fixed issues |
| CalciteToDBSPCompiler.java | Refactors INTERSECT logic by extracting indexEntireTuple method and converting input types to result type during indexing |
Comment on lines
+2383
to
+2384
| /** Given an operator with output type ZSet[T], index is using | ||
| * (ZSet[S], Tup0). */ |
There was a problem hiding this comment.
The documentation comment is unclear. It should explain that this method indexes a ZSet by its entire tuple as the key, converting from input type S to result type T, and producing an indexed ZSet with an empty value tuple (Tup0).
Suggested change
| /** Given an operator with output type ZSet[T], index is using | |
| * (ZSet[S], Tup0). */ | |
| /** | |
| * Given an operator whose output is a {@code ZSet<S>}, create an indexed ZSet that | |
| * uses the entire tuple as the key and an empty tuple ({@code Tup0}) as the value. | |
| * <p> | |
| * The input tuples of type {@code S} are cast to {@code resultType} (type {@code T}) | |
| * and used as the key type of the resulting {@code IndexedZSet<T, Tup0>}. | |
| */ |
| @Test | ||
| public void issue5425() { | ||
| this.statementsFailingInCompilation(""" | ||
| CREATE TABLE tbl( |
There was a problem hiding this comment.
Extra space between 'TABLE' and 'tbl' should be removed.
Suggested change
| CREATE TABLE tbl( | |
| CREATE TABLE tbl( |
rivudhk
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5425
Fixes #5484