Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@igorscs
Copy link
Contributor

@igorscs igorscs commented Jan 22, 2026

nodejs v20 is needed for the styleText in the webconsole, we use version 20 in our build Docker image

Checklist

  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

Describe Incompatible Changes

Add a few sentences describing the incompatible changes if any.

@igorscs igorscs self-assigned this Jan 22, 2026
@igorscs igorscs requested a review from Karakatiza666 January 22, 2026 17:56
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it's sufficient, I had problems with some versions >= 20 in the past.
I have 25 for now.

@Karakatiza666
Copy link
Contributor

I have Node 20 locally, so that should work; the issue must've been something else

@igorscs
Copy link
Contributor Author

igorscs commented Jan 22, 2026

I am not sure it's sufficient, I had problems with some versions >= 20 in the past. I have 25 for now.

Without version 20 it won't compile. We use version 20 in our build image
https://github.com/feldera/feldera/blob/main/deploy/build.Dockerfile#L70

@mihaibudiu
Copy link
Contributor

I just said that I am not sure that all versions above 20 will work.

@igorscs
Copy link
Contributor Author

igorscs commented Jan 22, 2026

I just said that I am not sure that all versions above 20 will work.

Got it, thanks. I will update readme to use exact version 20.

@Karakatiza666
Copy link
Contributor

In that case mention both 20 and 25 as "confirmed to work", I guess

Need new styleText for the webconsole
We use nodejs v20 in our build docker image
@igorscs igorscs force-pushed the readme-update-deps branch from e9cc482 to 6abadfc Compare January 22, 2026 19:00
@igorscs
Copy link
Contributor Author

igorscs commented Jan 22, 2026

In that case mention both 20 and 25 as "confirmed to work", I guess

I think we better guide users to install the same version as we use in our build Docker image.
Just to use the same compilation env as we use.

@igorscs igorscs added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit fad94e5 Jan 22, 2026
1 check passed
@igorscs igorscs deleted the readme-update-deps branch January 22, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants