[SQL] Three bug fixes (3 commits) #5497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
Signed-off-by: Mihai Budiu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes three bugs related to SQL compilation and adds documentation for window aggregate functions. The changes include fixing issues #5491 and #5493, along with improvements to variable naming and code organization in the compiler internals.
Changes:
- Fixed bug related to safe cast operations in SQL compilation
- Fixed bug related to lateness types handling in incremental compilation
- Improved variable naming and index tracking in join operations for better code clarity
- Added documentation for
FIRST_VALUEandLAST_VALUEwindow aggregate functions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Regression2Tests.java | Added test case for issue #5493 validating SAFE_CAST with MAP types |
| IncrementalRegressionTests.java | Re-enabled test for issue #5491 (previously ignored) by removing @ignore annotation |
| InsertLimiters.java | Improved variable naming and fixed index tracking bug in join filter processing |
| ExpandSafeCasts.java | Fixed bug by moving nullable handling outside conditional block and removed unused import |
| ReferenceMap.java | Enhanced error message to include declaration IDs for better debugging |
| CalciteToDBSPCompiler.java | Fixed variable scope issue by creating new variable per iteration in projection loop |
| aggregates.md | Added documentation for FIRST_VALUE and LAST_VALUE window aggregate functions |
.../src/main/java/org/dbsp/sqlCompiler/compiler/visitors/outer/monotonicity/InsertLimiters.java
Outdated
Show resolved
Hide resolved
| <tr> | ||
| <td><a id="last_value"></a><code>LAST_VALUE(expression)</code></td> | ||
| <td>Returns the value of <code>expression</code> at the last row of the window frame. | ||
| Currently only supported for windows with <code>UNLIMITED RANGE</code></td> |
There was a problem hiding this comment.
Missing period at the end of the sentence for consistency with other function descriptions.
Suggested change
| Currently only supported for windows with <code>UNLIMITED RANGE</code></td> | |
| Currently only supported for windows with <code>UNLIMITED RANGE</code>.</td> |
Signed-off-by: Mihai Budiu <[email protected]>
rivudhk
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5491
Fixes #5493
I also documented our (partial) support for
FIRST_VALUEandLAST_VALUEwindow aggregates.