[adapters] Report "/status" correctly during replay. #5503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status was being reported as running while replay was in progress. This fixes the problem. Signed-off-by: Ben Pfaff <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the status reporting endpoint to correctly report Replaying status during replay operations instead of incorrectly showing Running.
Changes:
- Refactored status determination logic to check for replay state before returning the default pipeline state
- Extracted common status logic into an
inner_statushelper function to eliminate code duplication
Comment on lines
+1332
to
+1336
| fn inner_status( | ||
| runtime_desired_status: RuntimeDesiredStatus, | ||
| controller: &Controller, | ||
| default_status: RuntimeStatus, | ||
| ) -> ExtendedRuntimeStatus { |
There was a problem hiding this comment.
The nested function name inner_status is vague and doesn't clearly indicate its purpose. Consider renaming it to compute_extended_runtime_status or build_status_with_replay_check to better reflect that it's computing status while checking for bootstrapping and replay states.
mihaibudiu
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status was being reported as running while replay was in progress. This fixes the problem.