py: add illegal argument tests for CAST operator #5511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the CAST operator by introducing illegal argument tests that verify both valid and invalid casting operations across different data types.
Changes:
- Added a new test file with test cases for CAST and SAFE_CAST operations across all data types
- Imported the new test module in the test suite main file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/tests/runtime_aggtest/illarg_tests/test_cast.py | New test file containing 31 test classes that verify CAST operator behavior for legal conversions and expected error cases across all data types (INT, DECIMAL, REAL, DOUBLE, BOOLEAN, VARCHAR, BINARY, TIMESTAMP, DATE, TIME, UUID, ARRAY, MAP, ROW, UDT) |
| python/tests/runtime_aggtest/illarg_tests/main.py | Added import statement to include the new CAST operator tests in the test suite |
| self.sql = """CREATE MATERIALIZED VIEW cast_timestamp_legal AS SELECT | ||
| SAFE_CAST(tmestmp AS INT) AS to_int, | ||
| CAST(tmestmp AS DECIMAL) AS to_decimal, | ||
| SAFE_CAST(tmestmp AS DECIMAL(6,2)) AS to_decimal, |
There was a problem hiding this comment.
The column alias 'to_decimal' is used for two different columns in this query (lines 182 and 183). The second usage should have a distinct name like 'to_decimal0' to match the data structure at line 172.
Suggested change
| SAFE_CAST(tmestmp AS DECIMAL(6,2)) AS to_decimal, | |
| SAFE_CAST(tmestmp AS DECIMAL(6,2)) AS to_decimal0, |
Contributor
There was a problem hiding this comment.
yes, I think this needs to be fixed
mihaibudiu
approved these changes
Jan 26, 2026
Signed-off-by: rivudhk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.