py: add tests for unsigned integer type #5518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for unsigned integer types (TINYINT UNSIGNED, SMALLINT UNSIGNED, INTEGER UNSIGNED, BIGINT UNSIGNED) in the Python test suite. The tests verify that various SQL operations, functions, and expressions work correctly with unsigned integer types.
Changes:
- Added test tables and views for generating unsigned integer test data using the datagen connector
- Implemented tests for comparison operators, conditional expressions, and SQL predicates with unsigned integers
- Added tests for arithmetic functions, trigonometric functions, and string operations applied to unsigned integers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/tests/runtime_aggtest/unsigned_int_tests/test_un_int_tbl.py | Defines test tables and views with unsigned integer columns using datagen connector for data generation |
| python/tests/runtime_aggtest/unsigned_int_tests/test_un_int_supported_functions.py | Tests comparison operators, conditional logic, NULL handling, and string functions with unsigned integers |
| python/tests/runtime_aggtest/unsigned_int_tests/test_un_int_arith_fn.py | Tests arithmetic and mathematical functions (trigonometric, logarithmic, rounding) with unsigned integers |
| python/tests/runtime_aggtest/unsigned_int_tests/main.py | Entry point that imports all test modules and executes the unsigned integer test suite |
|
|
||
|
|
||
| class un_int_datagen_tbl(TstTable): | ||
| """Define the table used by unsigned integer tests the uses datagen connector to generate data""" |
There was a problem hiding this comment.
Corrected grammar from 'the uses' to 'that uses'.
Suggested change
| """Define the table used by unsigned integer tests the uses datagen connector to generate data""" | |
| """Define the table used by unsigned integer tests that use the datagen connector to generate data""" |
936a184 to
5b750c5
Compare
mihaibudiu
reviewed
Jan 27, 2026
| { | ||
| "id": 0, | ||
| "tiny_un_int": Decimal("8103.083927575384"), | ||
| "small_un_int": None, |
| # LEN | ||
| class un_int_len(TstView): | ||
| def __init__(self): | ||
| self.data = [{"tiny_int": 1, "small_int": 5, "intt": 10, "big_int": 19}] |
Contributor
There was a problem hiding this comment.
didn't know that len works on numbers
Signed-off-by: rivudhk <[email protected]>
mihaibudiu
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4331