[adapters] NATS: Fix "consumer already exists" error for named consumers #5526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where NATS pipelines with named consumers would fail with "consumer already exists" errors during rapid restarts or replays before the previous consumer expires.
Changes:
- Append a unique UUID suffix to explicitly named NATS consumers to prevent name collisions
- Add error context when consumer creation fails
- Add test case verifying named consumers work correctly during restart/replay cycles
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/adapters/src/transport/nats/input.rs | Implements UUID suffix for named consumers and improves error messages |
| crates/adapters/src/transport/nats/input/test.rs | Adds test infrastructure and test case for named consumer restart scenarios |
gz
approved these changes
Jan 28, 2026
Add test to check that we do not get error/bug "consumer exist", that we got when pipeline with a named nats consumer got restarted/replayed. Signed-off-by: kfollesdal <[email protected]>
This is a fix for the bug "consumer exist" that we get when we had a named NATS consumer in a pipline that got restarted/replayed. Signed-off-by: kfollesdal <[email protected]>
Signed-off-by: kfollesdal <[email protected]>
60db74f to
1b94bba
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #5525, by @kfollesdal, copied into the feldera upstream repo to enable the CI system to work with it (currently feldera CI isn't able to work with external repos).
Description:
Fixes a bug where pipelines with named NATS consumers would fail with "consumer already exists" errors during rapid restarts or replays, before the previous consumer expires (inactive_threshold).
Changes: