manager: expose the checkpoints api #5529
Merged
+315
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da1d26c to
5ab5ab5
Compare
blp
approved these changes
Jan 29, 2026
Expose the `/checkpoints` api that allows us to list a pipeline's current checkpoints. Adapts the downstream tests to use this api instead of blindly waiting. Also, adapts the `/checkpoint/sync` api to use the same logic as the `/checkpoints` api, as for some reason, there seems to be a delay between when the `checkpoints.feldera` file shows checkpoints vs when the `controller.inner.last_checkpoint()` method shows it. From the code, I cannot tell why there is this delay, but it causes the downstream tests to be flaky. This commit fixes it. Signed-off-by: Abhinav Gyawali <[email protected]>
5ab5ab5 to
ab22d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
/checkpointsapi that allows us to list a pipeline's current checkpoints.Adapts the downstream tests to use this api instead of blindly waiting.
Also, adapts the
/checkpoint/syncapi to use the same logic as the/checkpointsapi, as for some reason, there seems to be a delay between when thecheckpoints.felderafile shows checkpoints vs when thecontroller.inner.last_checkpoint()method shows it. From the code, I cannot tell why there is this delay, but it causes the downstream tests to be flaky. This commit fixes it.Checklist