[python] In tests, print deployment status while waiting for it to ch… #5533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange. We've seen timeouts in places where they shouldn't happen. This ought to help understand what's happening. Signed-off-by: Ben Pfaff <[email protected]>
mihaibudiu
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds debug logging to help diagnose timeout issues in deployment status tests. When waiting for deployment status changes, the code now prints the current status and elapsed time whenever the status changes.
Changes:
- Added timing information to track elapsed time during deployment status polling
- Introduced debug print statements to log status changes with timestamps
| last = obj.get("deployment_status") | ||
| status = obj.get("deployment_status") | ||
| if status != last: | ||
| print(f"After {time.time() - start:.1f} seconds: status is {status}") |
There was a problem hiding this comment.
Using print() for debugging in tests is not ideal. Consider using a proper logging framework (e.g., Python's logging module) which can be configured to different levels and outputs. This would allow better control over when these messages appear and make them easier to filter or disable in production test runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ange.
We've seen timeouts in places where they shouldn't happen. This ought to help understand what's happening.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes