[python] More refinement of integration tests. #5536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional prints should help narrow down test failures. The added wait_for_deployment_status is a little harder to defend, but it might help too. Signed-off-by: Ben Pfaff <[email protected]>
mihaibudiu
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances integration test debugging capabilities by adding diagnostic print statements and an additional state transition check to help identify and troubleshoot test failures related to pipeline lifecycle operations.
Changes:
- Added diagnostic print statement showing the delay value being tested in each iteration
- Added
wait_for_deployment_statuscall to ensure pipeline has transitioned away from "Stopped" state before proceeding - Added print statement in
wait_for_deployment_statushelper to show what state transition is being awaited
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/tests/platform/test_pipeline_lifecycle.py | Added debug output and explicit wait for state transition after starting pipeline |
| python/tests/platform/helper.py | Added diagnostic print to show wait parameters when checking deployment status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional prints should help narrow down test failures. The added wait_for_deployment_status is a little harder to defend, but it might help too.