pytests: fix flaky checkpoint sync test #5537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sync tests, wait until the most recently checkpoint, the one with all the data is synced. This didn't show up previously, as all the data was inserted and executed within the checkpoint interval of 5s, and this checkpoint was synced within the interval of 10s. Signed-off-by: Abhinav Gyawali <[email protected]>
6a3251f to
4b6be5a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the checkpoint sync test to wait for the most recent checkpoint (containing all data) to be synced, reducing flakiness in automated sync scenarios.
Changes:
- Import
UUIDand use it to compare checkpoint identifiers to ensure the synced checkpoint is at least as recent as the created checkpoint. - Add additional logging of checkpoint UUIDs for easier debugging.
- Introduce a brief delay and new assertions in both automatic and manual sync paths to ensure the expected checkpoint has been synced.
swanandx
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sync tests, wait until the most recently checkpoint, the one with all the data is synced.
This didn't show up previously, as all the data was inserted and executed within the checkpoint interval of 5s, and this checkpoint was synced within the sync interval of 10s.