Thanks to visit codestin.com
Credit goes to github.com

Skip to content

⭐️ alpine binary support #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

chris-rock
Copy link
Contributor

This handles the special case for alpine to support embedded-postgres to be able to run in golang:1.16-alpine

@chris-rock
Copy link
Contributor Author

@fergusstrange I am unclear what I should add to improve the coverage. Any hint would be welcome.

@fergusstrange
Copy link
Owner

Hey great work @chris-rock!

I don't think we'll be able to get the core coverage stat that's failing the build up easily but as a work around I've created a branch and separate PR that runs an alpine linux tests within the Github Actions build here #24.

Try rebasing on top of this (there's a bunch of test commits in there that we can squash in the final merge) and see if the test passes as it currently doesn't without your changes.

This will definitely be enough to satisfy any dip in coverage.

@chris-rock
Copy link
Contributor Author

@fergusstrange Great! Thank you. I rebased and squashed the commits.

@fergusstrange
Copy link
Owner

Ah I missed an absolute reference to go in the tests. Know the fix ?

@chris-rock
Copy link
Contributor Author

@fergusstrange Alpine build is fixed and all is green! Thank you for your help

@fergusstrange fergusstrange merged commit a50b550 into fergusstrange:master Apr 16, 2021
@fergusstrange
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants