Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove archiver xz dependencies #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 22, 2021

Conversation

fergusstrange
Copy link
Owner

No description provided.

github.com/stretchr/testify v1.6.1
github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried that you're going to use an xz library from 2017 (!!).
It seems like https://github.com/ulikunitz/xz is more recommended... (it's even recommended on the README.md of the above library)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is the library we've been using under the hood from mholt archiver, and is a lighter weight version of ulikunitz/xz when we only need decompression. The README suggests to use ulikunitz/xz when compression is needed, which we can get away without.

This should help us avoid any issues on migration as like decompression algorithm won't have changed, and avoid having to track any of the CVEs which keep cropping up in mholt/archiver. Happy to assess this moving forward if this one crops up in any vulnerability scans or there are issues but it appears to have been a pretty rock solid library for that long!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that we don't use the xz capabilities (as since my last PR, we're setting binariesPath manually), so - whatever I say here is not going to affect our usage at all.

With that said, I feel like this library is completely abandoned. It's old (as noted), and doesn't even use go.mod (it doesn't have any dependencies, but still).

I understand that a "heavier" package, which also supports compression might be more exposed to potential vulnerabilities, but with ulikunitz/xz, I at least feel like - if there will be one - it'll get fixed (e.g. ulikunitz/xz@69c6093).

As noted above - your decision here will not affect me in any way - so - make sure it makes sense to what you're going to use it for...

Thanks!

Copy link
Collaborator

@steinfletcher steinfletcher Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a library hasn't been updated in a while it can also be a good thing - it can mean the API is stable/feature complete and there are no bugs.

@fergusstrange fergusstrange merged commit b5602a5 into master Nov 22, 2021
@fergusstrange fergusstrange deleted the remove_archiver_xz_dependencies branch November 22, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants