Prevent concurrent downloads using singleflight #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only attempt to download a given URL once in a given Go process. The singflight package ensures that an action will only be taken once for a set of concurrent Go routines. Other Go rountines will wait until the operation has completed.
|
I think I've got to the point where the test failure aren't due to my change. |
|
Hey @kyleconroy, We're not keen on introducing any dependencies into the library. The work done at #105 appears to be almost identical, and has some small changes to remove the current usage of the atomic library. Feel free to chip in there and also let me know if this PR was intended to solve a different issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt to download a given URL once in a given Go process. The singflight package ensures that an action will only be taken once for a set of concurrent Go routines. Other Go rountines will wait until the operation has completed.