[ReleaseBranch] Substitute v2-beta: Rework substitution logic #139

notanengineercom · 2020-10-11T16:40:47Z

This branch is the base of v2 (feature branch).
It contains the base of the new structure.
All existing features are supported, with a few changes.

💥 Breaking Changes

Setting multiple return values will use the last value instead of undefined after all the values have been used

👀

FluffySpoon.JavaScript.Testing.Faking/spec/regression/resolves.spec.ts

Lines 25 to 33 in 6893b7d

    
           test('resolves different values in the specified order on a method', async t => { 
        
             const calculator = Substitute.for<Calculator>() 
        
             calculator.heavyOperation(Arg.any('number')).resolves(1, 2, 3) 
        
             t.is(await calculator.heavyOperation(0), 1) 
        
             t.is(await calculator.heavyOperation(0), 2) 
        
             t.is(await calculator.heavyOperation(0), 3) 
        
             t.is(await calculator.heavyOperation(0), 3) // https://github.com/nsubstitute/NSubstitute/blob/master/tests/NSubstitute.Acceptance.Specs/ReturningResults.cs#L37-L42 
        
           })

✨ New Features

Logging a substitution will print a custom object with all calls
- 👀
Clearing / resetting a Substitute

🎨 Improvements

Nicer and clearer assertion messages
- 👀

This includes SubstituteBase, SubstituteException, Arguments, Utilities

* move existing tests to regression folder * add RecordedArguments spec * create Utilities spec

* improve proxy creation function * use node contexts to simplify node logic * implement custom records set RecordsSet implements the higher order filter and map methods which get applied when retrieving the iterator. This increases performance as it doesn't create arrays on each .map or .filter -> the iterator yields only the end values with one iteration

resolves #46 * implement clearSubstitute * add clearSubstitute spec

ffMathy · 2021-10-04T05:42:40Z

Awesome work so far. Looking forward to it being ready for review!

notanengineercom · 2021-10-04T08:31:15Z

Thanks 😄
You can see in the v2-release project board what's still pending. A refactor is due before the final v2 release too.
By the way, what do you think of releasing a beta version of the library with the latest commit on this branch?
People can start experimenting with v2, using the new features and worst case scenario, report back issues.
In theory everything is working (regression and new tests are green), but you never know 🤷‍♂️

ffMathy · 2021-10-04T09:20:06Z

I see no issues with that, but then I think this project should also have its own CI pipeline. Because right now, it's hard to do, because everything is published using https://github.com/ffMathy/FluffySpoon.Publishers.

notanengineercom · 2021-10-04T11:22:36Z

That's what I wanted to suggest, it would great to have the release system in a Github Action.
This would also allow us to have a better control on what gets included in the release (packing the built lib is visible in the repo), to avoid having a release per commit to master, and to align the package.json with the npm version number.

ffMathy · 2021-10-04T11:24:31Z

Indeed! Feel free to make an actions.yml file in this repo that does all the heavy lifting. Then I'll create a repo secret for the NuGet API key.

ffMathy · 2021-10-04T11:25:26Z

In the long run though, FluffySpoon.Publishers will transition into being based on actions itself though. But that won't be in the next foreseeable future.

notanengineercom · 2021-10-04T12:57:23Z

Sure, that sounds like a good idea 👍

Then I'll create a repo secret for the NuGet API key.

We need a NPM api key, don't we?
Moving FluffySpoon.Publishers to a Github Action would be ideal, but I don't think it's crucial right now 😄

ffMathy · 2021-10-04T13:25:20Z

I already have a key 😊 if you can make it work with placeholder values for the key, I'll insert the real one as a GitHub secret 😊🙏

notanengineercom · 2021-10-04T21:35:42Z

I just merged a publish github action, which publishes both to npm and github.
I think both failed due to lack of permissions (github) and no npm token (npm). Or might be missing something 😆
Could you try removing the release I created, and creating a new one again? (only important bit here is the tag name)

notanengineercom · 2021-10-04T21:37:47Z

The npm token name for the secrets is npm_token. The github one I assume is the self generated one - which I think only you have write permissions when used

ffMathy · 2022-06-02T07:26:07Z

I tried committing something to retry now. Hopefully it works. @notanengineercom not sure what happened, but somehow your message got lost in translation. I'll try to follow up on it soon, so we can get this beautiful work out.

As for coding styles though, I think you should re-add the semicolons, but we can do that later too.

notanengineercom added 7 commits October 11, 2020 18:28

add ts-node

ef92b07

create linked list classes

3ceef2f

minor refactoring

990b743

add root substitute graph

c2322c2

replace context with contextNode

de52c77

add recorded arguments class

cc5f11b

add working returns example

329a40a

notanengineercom added enhancement New feature or request wip Work in progress - should not merge labels Oct 11, 2020

notanengineercom self-assigned this Oct 11, 2020

notanengineercom added the hacktoberfest-accepted label Oct 11, 2020

notanengineercom added 7 commits September 11, 2021 21:16

Merge branch 'master' into v2-beta

08df650

update dependencies

6bf0838

add compile key to ava config

612d7fa

refactor existing interfaces

68517e4

This includes SubstituteBase, SubstituteException, Arguments, Utilities

replace linked list implementations with recorder + node

fd08599

rework substitute implementation

53e0683

refactor Arguments.ts

a4342bf

notanengineercom changed the title ~~Substitute v2-beta: Replace context switches with nodes in linked lists~~ Substitute v2-beta: Rework substitution logic Sep 12, 2021

notanengineercom mentioned this pull request Sep 12, 2021

Substitute v2-beta: Tests refactor #231

Merged

notanengineercom removed the hacktoberfest-accepted label Sep 12, 2021

notanengineercom changed the title ~~Substitute v2-beta: Rework substitution logic~~ [ReleaseBranch] Substitute v2-beta: Rework substitution logic Sep 12, 2021

notanengineercom added 3 commits October 3, 2021 22:32

Substitute v2-beta: Tests (#231)

77a2032

* move existing tests to regression folder * add RecordedArguments spec * create Utilities spec

Add clear substitute (#233)

42a137d

resolves #46 * implement clearSubstitute * add clearSubstitute spec

notanengineercom added the ✨v2 release label Oct 3, 2021

notanengineercom added 2 commits October 4, 2021 23:24

Merge branch 'master' into v2-beta

0de266a

2.0.0-beta.0

20f0808

notanengineercom and others added 4 commits October 21, 2021 23:21

Merge branch 'master' into v2-beta

bfcb908

Merge branch 'master' into v2-beta

ebda33a

refactor and add recorder related specs (#236)

0bb0590

Update package.json

b553b3e

ffMathy merged commit 6e3011a into master Jun 2, 2022

ffMathy deleted the v2-beta branch June 2, 2022 07:26

ffMathy added this to the v2.0 milestone Mar 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[ReleaseBranch] Substitute v2-beta: Rework substitution logic #139

[ReleaseBranch] Substitute v2-beta: Rework substitution logic #139

Uh oh!

notanengineercom commented Oct 11, 2020 •

edited

Loading

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Jun 2, 2022

Uh oh!

Uh oh!

	test('resolves different values in the specified order on a method', async t => {
	const calculator = Substitute.for<Calculator>()
	calculator.heavyOperation(Arg.any('number')).resolves(1, 2, 3)

	t.is(await calculator.heavyOperation(0), 1)
	t.is(await calculator.heavyOperation(0), 2)
	t.is(await calculator.heavyOperation(0), 3)
	t.is(await calculator.heavyOperation(0), 3) // https://github.com/nsubstitute/NSubstitute/blob/master/tests/NSubstitute.Acceptance.Specs/ReturningResults.cs#L37-L42
	})

Uh oh!

[ReleaseBranch] Substitute v2-beta: Rework substitution logic #139

[ReleaseBranch] Substitute v2-beta: Rework substitution logic #139

Uh oh!

Conversation

notanengineercom commented Oct 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💥 Breaking Changes

✨ New Features

🎨 Improvements

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

notanengineercom commented Oct 4, 2021

Uh oh!

ffMathy commented Jun 2, 2022

Uh oh!

Uh oh!

notanengineercom commented Oct 11, 2020 •

edited

Loading