Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add node 18 support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgao54 merged 4 commits into from
Apr 17, 2023
Merged

add node 18 support #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc12bfc
test
jgao54 Apr 14, 2023
a444962
make unsafe-perm faile silently; not supported in node18
jgao54 Apr 14, 2023
7b12381
fix tests
jgao54 Apr 14, 2023
0dafca4
comment out log
jgao54 Apr 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
name: "Linux Tests"
strategy:
matrix:
node: [14, 16]
node: [14, 16, 18]
runs-on: ubuntu-latest
container: ubuntu:16.04
container: ubuntu:20.04
steps:
- name: Install Dependencies for Ubuntu
# git >= 2.18 required for actions/checkout git support
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
# There is a race condition in node/generate that needs to be fixed
run: |
chown root .
npm set unsafe-perm true
npm set unsafe-perm true || true
node utils/retry npm install

- name: Test
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
name: "macOS Tests"
strategy:
matrix:
node: [14, 16]
node: [14, 16, 18]
runs-on: macOS-10.15
# This is mostly the same as the Linux steps, waiting for anchor support
# https://github.com/actions/runner/issues/1182
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@figma/nodegit",
"description": "Node.js libgit2 asynchronous native bindings",
"version": "0.28.0-figma.2",
"version": "0.28.0-figma.3",
"homepage": "http://nodegit.org",
"keywords": [
"libgit2",
Expand Down
5 changes: 4 additions & 1 deletion test/tests/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,10 @@ describe("Clone", function() {
});
});

it("can clone with git", function() {
// Since 15 March the unauthenticated git protocol on port 9418 is no longer
// supported in Github.
// https://github.blog/2021-09-01-improving-git-protocol-security-github/
it.skip("can clone with git", function() {
var test = this;
var url = "git://github.com/nodegit/test.git";
var opts = {
Expand Down
18 changes: 9 additions & 9 deletions test/tests/repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,15 @@ describe("Repository", function() {
return this.constRepository.statistics()
.then(function(analysisReport) {

assert.equal(analysisReport.repositorySize.commits.count, 992);
assert.equal(analysisReport.repositorySize.commits.size, 265544);
assert.equal(analysisReport.repositorySize.trees.count, 2416);
assert.equal(analysisReport.repositorySize.trees.size, 1188325);
assert.equal(analysisReport.repositorySize.trees.entries, 32571);
assert.equal(analysisReport.repositorySize.blobs.count, 4149);
assert.equal(analysisReport.repositorySize.blobs.size, 48489622);
assert.equal(analysisReport.repositorySize.commits.count, 993);
assert.equal(analysisReport.repositorySize.commits.size, 265772);
assert.equal(analysisReport.repositorySize.trees.count, 2418);
assert.equal(analysisReport.repositorySize.trees.size, 1189264);
assert.equal(analysisReport.repositorySize.trees.entries, 32590);
assert.equal(analysisReport.repositorySize.blobs.count, 4150);
assert.equal(analysisReport.repositorySize.blobs.size, 48489634);
assert.equal(analysisReport.repositorySize.annotatedTags.count, 1);
assert.equal(analysisReport.repositorySize.references.count, 8);
assert.equal(analysisReport.repositorySize.references.count, 9);

assert.equal(analysisReport.biggestObjects.commits.maxSize, 956);
assert.equal(analysisReport.biggestObjects.commits.maxParents, 2);
Expand All @@ -382,7 +382,7 @@ describe("Repository", function() {

assert.equal(analysisReport.biggestCheckouts.numDirectories, 128);
assert.equal(analysisReport.biggestCheckouts.maxPathDepth, 10);
assert.equal(analysisReport.biggestCheckouts.maxPathLength, 107);
assert.equal(analysisReport.biggestCheckouts.maxPathLength, 277);
assert.equal(analysisReport.biggestCheckouts.numFiles, 514);
assert.equal(analysisReport.biggestCheckouts.totalFileSize, 5160886);
assert.equal(analysisReport.biggestCheckouts.numSymlinks, 2);
Expand Down