Conversation
8af9c10 to
86cd266
Compare
b3e9765 to
3d47ec0
Compare
jgao54
commented
Jan 30, 2024
| "name": "@figma/nodegit", | ||
| "description": "Node.js libgit2 asynchronous native bindings", | ||
| "version": "0.28.0-figma.3", | ||
| "version": "0.28.0-figma.5", |
Author
There was a problem hiding this comment.
bumped to v5 because we have v4 in s3 for some reason
3d47ec0 to
d1ec05e
Compare
jfirebaugh
approved these changes
Jan 30, 2024
Member
|
Feel free to drop node 16 support too. |
d1ec05e to
123d895
Compare
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@jgao54 looks like Linux ARM support was removed ... do you know why? We (Retool) would love to have it added back. |
This was referenced Apr 15, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-gypGHA finally introduced m1 beta support. I tried it and some tests were failing, going to keep this PR just to linux arm support for now.