Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix lintchecks module #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

Fix lintchecks module #1117

merged 1 commit into from
Jan 23, 2018

Conversation

@SUPERCILEX
Copy link
Collaborator

@SUPERCILEX SUPERCILEX commented Jan 23, 2018

Fixes #1116

We'll only get lint errors on our debug builds, but this means we don't have to publish the module. 👍

@SUPERCILEX SUPERCILEX requested a review from samtstern as a code owner January 23, 2018 01:18
@samtstern samtstern added this to the 3.2.1 milestone Jan 23, 2018
@samtstern samtstern changed the base branch from master to version-3.2.1-dev January 23, 2018 16:06
@samtstern samtstern merged commit d9200ec into firebase:version-3.2.1-dev Jan 23, 2018
@samtstern
Copy link
Contributor

samtstern commented Jan 23, 2018

Confirmed:

$ diff ~/.m2/repository/com/firebaseui/firebase-ui-auth/3.2.0/firebase-ui-auth-3.2.0.pom ~/.m2/repository/com/firebaseui/firebase-ui-auth/3.2.1-SNAPSHOT/firebase-ui-auth-3.2.1-SNAPSHOT.pom
6c6
<   <version>3.2.0</version>
---
>   <version>3.2.1-SNAPSHOT</version>
49,54d48
<       <scope>runtime</scope>
<     </dependency>
<     <dependency>
<       <groupId>firebaseui-android.internal</groupId>
<       <artifactId>lintchecks</artifactId>
<       <version>unspecified</version>

@SUPERCILEX SUPERCILEX deleted the patch-1 branch January 23, 2018 16:17
@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Jan 23, 2018

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samtstern samtstern samtstern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@SUPERCILEX @samtstern