Enable artifactory publication #1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibeba857c25ee0739ac20b1a11e34fc2448709f80
samtstern
commented
Feb 12, 2018
build.gradle
Outdated
| } | ||
|
|
||
| artifactory { | ||
| contextUrl = 'http://localhost:8081/artifactory' |
Contributor
Author
There was a problem hiding this comment.
Need to replace this with real credentials for oss.jfrog
Change-Id: I6a65ded32170be4f4a9ba1dd5965ac2192b03934
samtstern
commented
Feb 12, 2018
| @@ -0,0 +1,8 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| ./gradlew :library:prepareArtifacts | |||
Contributor
Author
There was a problem hiding this comment.
I can't explain it, but this script is the only way I can get things to work. Gradle task dependencies randomly skips some of these.
Change-Id: I094826c18cdf9d4604a0409d8540556f6b828e7f
Contributor
Author
|
I must have messed something up because I am getting a ton of lint errors like this: |
Change-Id: I3efce1be42057503dc19cb90bfa20a0326a6775e
Change-Id: Ia27e3b4019fc7e945f328204484e2f96b5260836
SUPERCILEX
approved these changes
Feb 14, 2018
Collaborator
SUPERCILEX
left a comment
There was a problem hiding this comment.
Wow, this looks amazing!!! Now we won't have to keep pointing people to JitPack to try the latest and greatest. 😁
| @@ -0,0 +1,10 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -e | |||
Collaborator
There was a problem hiding this comment.
I believe this can be inlined: #!/usr/bin/env bash -e.
Contributor
Author
There was a problem hiding this comment.
It didn't like that 🤷♂️
Change-Id: I8c32017d2408dc589e5fcf24dfe7b9a188bd8679
Change-Id: I651190bb25cf874690b992578bc75fd340a1a71b
SUPERCILEX
reviewed
Feb 14, 2018
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.5-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.5-bin.zip |
Collaborator
There was a problem hiding this comment.
Whoops, looks like this was a mistake.
Change-Id: I0d36fe4c3ee477ab28cfbdb78cca719ec6bed51b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables publication of
-SNAPSHOTbuilds on jFrog artifactory. Once I get it configured, this can run from Travis (!!!)