Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@samtstern
Copy link
Contributor

See #901

Change-Id: Ie03319754f361ce1fc5b1af7436671d4310965d0
@samtstern samtstern changed the base branch from master to version-3.2.2-dev February 21, 2018 20:30
@firebase firebase deleted a comment from googlebot Feb 21, 2018
@samtstern
Copy link
Contributor Author

I have kicked off the internal translation process for the new ones.

<string name="fui_error_email_does_not_exist" translation_description="Inline error when user attempt signin with invalid account">That email address doesn\'t match an existing account</string>

<!-- Other error messages -->
<string name="fui_error_unknown" translation_description="General error messages for an unknown failure.">An unknown error occurred.</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intentional or not, but we already have a very similar string:

<string name="fui_general_error" translation_description="Toast text flashing general error">An error has occurred.</string>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I will remove that one, I like it with 'unknown'

@samtstern samtstern added this to the 3.2.2 milestone Feb 21, 2018
Change-Id: Idbdf402da3fefb2c59eb7a54b12c68e6c7b16a2a
Change-Id: I0321a282f22ed9e8a25be82e207cb75dd73681cd
Change-Id: If832245eeacca6b0bb202cad0bb0d59918c55bde
@samtstern
Copy link
Contributor Author

Ok so it looks like our translation system decided to remove the translation_description attribute from strings in the translated files which makes this diff kind of enormous. I took a manual look at a few files and it looks like there are no other changes.

@samtstern samtstern merged commit cd13c29 into version-3.2.2-dev Feb 27, 2018
@samtstern samtstern deleted the translate-errors branch February 27, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants