Give clients much more detailed errors #1168
Conversation
Signed-off-by: Alex Saveau <[email protected]>
| DEVELOPER_ERROR | ||
| }) | ||
| @Retention(RetentionPolicy.SOURCE) | ||
| public @interface All {} |
There was a problem hiding this comment.
Not really happy with this name, any ideas?
There was a problem hiding this comment.
SGTM, ErrorCodes.Anything feels weird, but yours makes more sense.
| @@ -1,33 +1,46 @@ | |||
| package com.firebase.ui.auth.data.model; | |||
There was a problem hiding this comment.
Should we move this to the root package or leave it as is?
There was a problem hiding this comment.
Since this is LIBRARY_GROUP only that's not a breaking change, so if you want to move it to the root package that SGTM.
Signed-off-by: Alex Saveau <[email protected]>
| void onSuccess(@NonNull IdpResponse idpResponse); | ||
|
|
||
| void onFailure(); | ||
| void onFailure(@NonNull Exception e); |
There was a problem hiding this comment.
Is it possible that anyone was relying on this interface? If so this is a breaking change .... if this is meant to be internal let's annotate it.
There was a problem hiding this comment.
I don't think so, or at least, I know we've broken it before without notice. I'll annotate it.
|
@SUPERCILEX thanks! Just left a few small comments. |
Signed-off-by: Alex Saveau <[email protected]>
Fixes #526