Rewrite email logic with new architecture #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
samtstern
reviewed
Apr 2, 2018
| // Email address is malformed | ||
| mEmailInput.setError(getString(R.string.fui_invalid_email_address)); | ||
| } else if (e instanceof FirebaseAuthUserCollisionException) { | ||
| // Collision with existing user email, it should be very hard for |
Contributor
There was a problem hiding this comment.
Are we changing our assumption from "very hard to get here" to "impossible to get here"? Fine with me, just confirming.
Contributor
There was a problem hiding this comment.
Oh nevermind, I see the StartWelcomeBackFlow in the ViewModel
Collaborator
Author
There was a problem hiding this comment.
Yup, moved that logic there.
| private void validateAndSignIn(String password) { | ||
| // Check for null or empty password | ||
| if (TextUtils.isEmpty(password)) { | ||
| mPasswordLayout.setError(getString(R.string.fui_required_field)); |
Contributor
There was a problem hiding this comment.
Should we return if the password is empty?
Collaborator
Author
There was a problem hiding this comment.
We do, it looks like the diff hides it 😉
| // Collision with existing user email, it should be very hard for | ||
| // the user to even get to this error due to CheckEmailFragment. | ||
| ProviderUtils.fetchTopProvider(getAuth(), email) | ||
| .addOnSuccessListener(new StartWelcomeBackFlow(email)); |
Contributor
There was a problem hiding this comment.
What about when this call fails too? Feels like we could get a case where the Resource never gets to a final state.
Signed-off-by: Alex Saveau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1213