Eliminate unnecessary starting of credential save activity for anti-social providers #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
samtstern
reviewed
Apr 4, 2018
| } | ||
|
|
||
| private void handleResponse(@NonNull IdpResponse response) { | ||
| if (!response.isSuccessful() |
Contributor
There was a problem hiding this comment.
Can we simplify this if statement? It's kinda melting my brain.
if (AuthUI.SOCIAL_PROVIDERS.contains(response.getProviderType())) {
handler.startSignIn(response)
} else if (response.isSuccessful()) {
finish(RESULT_OK, response.toIntent();
} else {
finish(RESULT_CANCELED, response.toIntent());
}
Collaborator
Author
There was a problem hiding this comment.
Unfortunately not, your thing will crash. The only reason I have the successful check is because the providerId will be null if it's a failure. Other ideas? (I agree that the statement is confusing, but that nullability is biting us in the behind.)
Signed-off-by: Alex Saveau <[email protected]>
Collaborator
Author
|
@samtstern changed the purpose and addressed your feedback, what do you think? |
Contributor
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern Well I dunno exactly where the error is coming from, but this fixes some ugliness we had with credential saving and should fix #1239 as a side effect.