4.0.0 docs #1304
Merged
4.0.0 docs #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I49ba7416bbeecaf21ada7c24f42cb4cbd82a8b54
SUPERCILEX
approved these changes
May 18, 2018
Collaborator
SUPERCILEX
left a comment
There was a problem hiding this comment.
Looks good! Do you think we should mention that AuthUI#signOut no longer immediately signs out? You used to be able to use it synchronously (though we never said you should).
|
Yes
…On Fri, May 18, 2018, 12:21 PM Alex Saveau ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good! Do you think we should mention that AuthUI#signOut no longer
immediately signs out? You used to be able to use it synchronously (though
we never said you should).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1304 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AlH51PRdv_MGShW5n7fPzkHrM_JdsPSRks5tzwMIgaJpZM4UFA8->
.
|
Contributor
Author
|
@SUPERCILEX I'll make sure to put that in the release notes but that's not a "breaking" change I don't think. It always returned a |
Collaborator
|
Yup, you're right. No concerns from me then! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.