Fix overlapping view and padding issues #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
…rewrite # Conflicts: # auth/src/main/java/com/firebase/ui/auth/data/remote/TwitterSignInHandler.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/VerifyPhoneNumberFragment.java # auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneActivityTest.java
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/HelperActivityBase.java # auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/CompletableProgressDialog.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/PhoneActivity.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/SubmitConfirmationCodeFragment.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/VerifyPhoneNumberFragment.java # auth/src/main/java/com/firebase/ui/auth/util/ui/PreambleHandler.java # auth/src/main/res/layout/fui_phone_progress_dialog.xml
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Contributor
|
😭 Thanks Alex! |
Contributor
|
@SUPERCILEX because this was based on #1253 it has to move to the |
…-fixes # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/HelperActivityBase.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/PhoneActivity.java # auth/src/main/java/com/firebase/ui/auth/util/ui/PreambleHandler.java # auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml # auth/src/main/res/layout/fui_auth_method_picker_layout.xml # auth/src/main/res/layout/fui_welcome_back_password_prompt_layout.xml # library/quality/quality.gradle
Collaborator
Author
|
@samtstern Any objections to merging? |
Contributor
|
@SUPERCILEX nope I had just forgotten, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lsirac once the diff becomes sane, I'd recommend taking a look at this one since it fixes issues with the ToS. Here's the simplest tip to learn out of this one: always test your layouts in the smallest possible split screen version of FUI.
@samtstern built on top of #1253 because that one fixes similar issues to deal with the progress bars in the phone layouts.
PS: here's what I'm talking about, not so pretty 😭:
