Start adding nullability annotations to all public or protected symbols #1326
Conversation
|
@SUPERCILEX I targeted this for |
|
Nope, that seems right to me. |
|
@SUPERCILEX this has ~1trillion merge conflicts. Still want to try and get this in for |
|
Eh, punt it. I'll get back to this later. |
Signed-off-by: Alex Saveau <[email protected]>
|
@samtstern This one should be fine to merge along with #1421 since it doesn't touch the auth module. 👍 TBH, I feel like the auth module has too many internal classes where nullability annotations don't matter for us to enable it. 🤷♂️ |
|
|
||
| lintOptions { | ||
| disable("UnusedQuantity") | ||
| disable("UnknownNullness") // TODO fix in future PR |
There was a problem hiding this comment.
I wonder if there's a way we could disable the nullness check on classes that have @RestrictTo but leave it on other public classes?
There was a problem hiding this comment.
Damn, that's a great idea! I'll file an issue for Tor.
There was a problem hiding this comment.
|
@SUPERCILEX LGTM |
Cough cough, ahem. Did you hear something? 😁
Built on top of #1321 which upgrades lint to a version that suggests adding nullability annotations to all public symbols. Also built on top of #1253 so I don't have to step all over myself.