Upgrade to Gradle 4.8 #1350
Upgrade to Gradle 4.8 #1350
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
…-4.8 # Conflicts: # build.gradle.kts
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
| organizationUrl.set("https://firebase.google.com") | ||
| roles.set(listOf("Project-Administrator", "Developer")) | ||
| timezone.set("-8") | ||
| } |
| } | ||
|
|
||
| object Plugins { | ||
| const val android = "com.android.tools.build:gradle:3.2.0-alpha15" |
There was a problem hiding this comment.
I didn't even notice that we had moved to alpha in the gradle --> kotlin switch. Is there anything more stable that will work for us?
There was a problem hiding this comment.
That was for lint to work. Also, we already shipped v4.0.1 without any problems so I wouldn't worry about it.
There was a problem hiding this comment.
Ohhhhhhhhh, but I forgot that it will make it hard for people to use the sample 😕. Well unless we want to undo a few weeks of PRs, there's no going back. Sorry about that! 😊
There was a problem hiding this comment.
NP let's just get onto a beta-or-better train as soon as one is available.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.7-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.8-all.zip |
There was a problem hiding this comment.
So has the issue we had with 4.8 been fixed?
There was a problem hiding this comment.
Yup, in bintray 1.8.1.
| organizationUrl.set("https://firebase.google.com") | ||
| roles.set(listOf("Project-Administrator", "Developer")) | ||
| timezone.set("-8") | ||
| } |
There was a problem hiding this comment.
BTW @lsirac totally optional, if you don't want to expose your email address or name you can skip.
|
I am going to merge and let @lsirac send a PR later for adding his credits to the POM (completely optional) |
No description provided.