Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SUPERCILEX
Copy link
Collaborator

Fixes #1242

Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX SUPERCILEX requested a review from samtstern as a code owner June 13, 2018 02:23
Signed-off-by: Alex Saveau <[email protected]>
@samtstern samtstern added this to the 4.1.0 milestone Jun 13, 2018
@samtstern
Copy link
Contributor

@SUPERCILEX thanks for doing this! Code LGTM.

Just wondering: what criteria did you use to find all the places where you care about the AuthResult? Is there any way we can generalize some of what you did so that we don't forget to pass through information from the AuthResult in future additions / refactors?

Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Copy link
Collaborator Author

@samtstern Yeah, I did a find on all calls to Resource#setResult and then looked for ones in a Firebase auth callback. I agree that we should generalize this so I added a base class with a helper method, but I don't see a way of enforcing that it's called instead of setResult directly. 🤷‍♂️

@samtstern
Copy link
Contributor

@SUPERCILEX this looks better to me, thanks for the refactor!

@samtstern samtstern merged commit 915846d into firebase:version-4.1.0-dev Jun 13, 2018
@SUPERCILEX SUPERCILEX deleted the new-user branch June 13, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants