Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Sep 15, 2025

This PR fixes the broken nightly tests.
Previously asyncio_default_fixture_loop_scope was set to None which was an invalid configuration. In pytest-asyncio v1.2.0, these misconfigurations now return errors. By removing this configuration, the default scope is set to function.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is the default scope function or session? Do we know which one is more suitable for us?

@jonathanedey
Copy link
Contributor Author

Thanks! Is the default scope function or session? Do we know which one is more suitable for us?

The default is function, sorry I think I miss read/typed. We currently don't have any async fixtures which is why I removed it. If we were to keep it and set a value, I would match the asyncio_default_test_loop_scope and set it to class.

@jonathanedey jonathanedey merged commit de713d2 into master Sep 16, 2025
13 checks passed
@jonathanedey jonathanedey deleted the je-fix-nightly branch September 16, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants