change int32 to int64#6577
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (a3242ce) and merge commit (1528a8a).Test Logs |
| // | ||
| // * Must be greater than zero when present. | ||
| int32 up_to = 1; | ||
| int64 up_to = 1; |
There was a problem hiding this comment.
This has to be google.protobuf.Int64Value.
There was a problem hiding this comment.
do we have google.protobuf.Int64Value in web sdk?
web sdk used google.protobuf.Int32Value, but didn't see any line uses google.protobuf.Int64Value. 🤔
There was a problem hiding this comment.
Yes, I believe we do have google.protobuf.Int64Value in the web sdk. Even if we don't it's fine because we never use it. But it's important that the proto definition is correct because if we ever do use it in the future then we want it to work correctly. Are you encountering errors when you change it to Int64Value?
dconeybe
left a comment
There was a problem hiding this comment.
I think you also need to run that command from update.sh to regenerate the code from the changed protos.
change int32 to int64 for up_to