Snippets for new Auth admin features #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rsgowman could you take a look at these? Even nitpicks on naming/comments are useful because once you approve of these I will use them as a template for the snippets in other languages. |
rsgowman
approved these changes
Mar 31, 2020
rsgowman
reviewed
Mar 31, 2020
| displayName: 'updatedName', | ||
| emailSignInConfig: { | ||
| enabled: false, // Disable email provider. | ||
| }, |
Member
There was a problem hiding this comment.
Originally, I had thought to just piggy-back the enablement of anon authentication docs into the existing create/update tenant docs. My reasoning was that this is just another parameter, not really much different than (eg) emailSignInConfig. If you did that here, you could get rid of the enableAnonAuth snippet entirely. (No objection to keeping it separate either though.)
This was referenced Mar 31, 2020
rsgowman
reviewed
Apr 2, 2020
rsgowman
reviewed
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get user by federated ID:
https://github.com/firebase/firebase-admin-node/pull/769/files
Link/unlink federated in update:
https://github.com/firebase/firebase-admin-node/pull/770/files
Enable anon auth in tenant config:
https://github.com/firebase/firebase-admin-node/pull/802/files