Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@deepak1556
Copy link
Contributor

updated to work for manifest_version 2. still have to change background.js script to connect to contentScript. currently there is no port creation.

@janodvarko
Copy link
Member

@galori: ping

Should we merge?

Honza

@deepak1556
Copy link
Contributor Author

chrome.tabs.getSelected and chrome.tabs.sendRequest are deprecated, have to be replaced with tabs.query and tabs.sendMessage. Should i go with maintaining persistent connection for requests or just go with the current one-time requests implementation ?

@janodvarko
Copy link
Member

Sorry for the delay. Gal (the guy who maintained Firebug Lite for some time) doesn't have time to help with the pull request.

Anyway, I believe that the problem should be fixed.

Would you have time to merge/test/release new version?
(I can provide you with necessary privileges)

I took quick look at the patch, but it look like the entire background.html has been changed, so I can't see the right changes. Did you change the end-of-line style?

Honza

@simonlindholm
Copy link
Member

I took quick look at the patch, but it look like the entire background.html has been changed, so I can't see the right changes. Did you change the end-of-line style?

No, indeed the whole file was changed (code moved into a .js file). You can ignore whitespace changes by appending ?w=1 to the diff link.

@deepak1556
Copy link
Contributor Author

@janodvarko @simonlindholm the manifest version 2 states no inline js should be run in background, so moved it to a seperate js file , also there are a quite a few deprecated methods used in the extension. I just started reworking the entire extension. Sorry for the delay in bug fix, will get it done soon. This patch should get the extension get installed properly.

@janodvarko
Copy link
Member

This sounds great, so please keep us updated.

Honza

@deepak1556
Copy link
Contributor Author

@janodvarko can v merge this and release a minor version so that users with chrome version > 18 wont take hit on the new manifest changes. if its ok i can help out with the new release.

Thanks

@deepak1556
Copy link
Contributor Author

Todo

  • Create a new build of firebug-lite-beta.js with absolute image paths in firebug.css for v1.5.1 release
  • Bugs and features
    • shift from browserAction to pageAction
    • change build system to grunt
    • Editing HTML and Js
    • Network tab
    • Patch the todos left by galori

just prepared list with what i will be working on once 1.5.1 is released. please edit/comment for improvements. also can you direct me to the existing tracker for firebug-lite, would like to work on improving it.

Thanks

@janodvarko
Copy link
Member

This is great!

Would you be interested in building new release of Firebug Lite?

We are hardworking on Firebug 1.13 (should be 2.0) and not having much time for Firebug Lite at the moment.

Please contact me: [email protected] we can discuss details.

Honza

@janodvarko
Copy link
Member

also can you direct me to the existing tracker for firebug-lite,

There are some FirebugLite related issues in the official issue list
https://code.google.com/p/fbug/issues/list?can=2&q=label%3Alite&colspec=ID+Type+Status+Owner+Test+Summary+Reporter&cells=tiles
(using label "lite")

But, I believe that using the issue tracker here on github.com is better.

Honza

@SebastianZ
Copy link
Member

also can you direct me to the existing tracker for firebug-lite,

There are some FirebugLite related issues in the official issue list https://code.google.com/p/fbug/issues/list?can=2&q=label%3Alite&colspec=ID+Type+Status+Owner+Test+Summary+Reporter&cells=tiles (using label "lite")

We also wanted to move the issues from the Google Code tracker to GitHub at some point, though we didn't have time yet to investigate whether that's possible without losing information.

Sebastian

@deepak1556
Copy link
Contributor Author

Thanks Honza.. @SebastianZ no successful scripts out there to achieve this :(

deepak1556 added a commit that referenced this pull request Nov 23, 2013
Changes for compatibility with manifest V2
@deepak1556 deepak1556 merged commit 5e11d78 into firebug:master Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants