-
Notifications
You must be signed in to change notification settings - Fork 58
starting fix #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starting fix #2
Conversation
|
@galori: ping Should we merge? Honza |
|
chrome.tabs.getSelected and chrome.tabs.sendRequest are deprecated, have to be replaced with tabs.query and tabs.sendMessage. Should i go with maintaining persistent connection for requests or just go with the current one-time requests implementation ? |
|
Sorry for the delay. Gal (the guy who maintained Firebug Lite for some time) doesn't have time to help with the pull request. Anyway, I believe that the problem should be fixed. Would you have time to merge/test/release new version? I took quick look at the patch, but it look like the entire background.html has been changed, so I can't see the right changes. Did you change the end-of-line style? Honza |
No, indeed the whole file was changed (code moved into a .js file). You can ignore whitespace changes by appending ?w=1 to the diff link. |
|
@janodvarko @simonlindholm the manifest version 2 states no inline js should be run in background, so moved it to a seperate js file , also there are a quite a few deprecated methods used in the extension. I just started reworking the entire extension. Sorry for the delay in bug fix, will get it done soon. This patch should get the extension get installed properly. |
|
This sounds great, so please keep us updated. Honza |
|
@janodvarko can v merge this and release a minor version so that users with chrome version > 18 wont take hit on the new manifest changes. if its ok i can help out with the new release. Thanks |
Todo
just prepared list with what i will be working on once 1.5.1 is released. please edit/comment for improvements. also can you direct me to the existing tracker for firebug-lite, would like to work on improving it. Thanks |
|
This is great! Would you be interested in building new release of Firebug Lite? We are hardworking on Firebug 1.13 (should be 2.0) and not having much time for Firebug Lite at the moment. Please contact me: [email protected] we can discuss details. Honza |
There are some FirebugLite related issues in the official issue list But, I believe that using the issue tracker here on github.com is better. Honza |
We also wanted to move the issues from the Google Code tracker to GitHub at some point, though we didn't have time yet to investigate whether that's possible without losing information. Sebastian |
|
Thanks Honza.. @SebastianZ no successful scripts out there to achieve this :( |
Changes for compatibility with manifest V2
updated to work for manifest_version 2. still have to change background.js script to connect to contentScript. currently there is no port creation.