Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

@codehag
Copy link
Contributor

@codehag codehag commented Jul 25, 2017

Associated Issue: #3433

Summary of Changes

  • ensure query is not empty

Gif
filesearch

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

looks great!

@codecov
Copy link

codecov bot commented Jul 25, 2017

Codecov Report

Merging #3442 into next will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #3442      +/-   ##
=========================================
- Coverage   50.5%   50.32%   -0.19%     
=========================================
  Files        109      109              
  Lines       4520     4525       +5     
  Branches     931      936       +5     
=========================================
- Hits        2283     2277       -6     
- Misses      2237     2248      +11
Impacted Files Coverage Δ
src/test/tests-setup.js 100% <ø> (ø) ⬆️
src/components/Editor/SearchBar.js 33.9% <100%> (+13.19%) ⬆️
src/utils/search/get-matches.js 100% <100%> (ø) ⬆️
src/test/tests-framework.js 100% <100%> (ø) ⬆️
src/actions/project-text-search.js 0% <0%> (-100%) ⬇️
src/reducers/project-text-search.js 31.57% <0%> (-68.43%) ⬇️
src/utils/search/project-search.js 94.73% <0%> (-5.27%) ⬇️
src/actions/sources.js 53.37% <0%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cac54...029d8d8. Read the comment docs.

@jasonLaster jasonLaster merged commit 9b24d3d into firefox-devtools:next Jul 25, 2017
jasonLaster pushed a commit to jasonLaster/debugger.html that referenced this pull request Jul 26, 2017
* FileSearch does not update match count

* make sure getMatches is safe
jasonLaster pushed a commit to jasonLaster/debugger.html that referenced this pull request Jul 27, 2017
* FileSearch does not update match count

* make sure getMatches is safe
jbhoosreddy pushed a commit to jbhoosreddy/debugger.html that referenced this pull request Aug 20, 2017
* FileSearch does not update match count

* make sure getMatches is safe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants