fix: pointer and signal handler casts#12488
Open
xtqqczze wants to merge 1 commit intofish-shell:masterfrom
Open
fix: pointer and signal handler casts#12488xtqqczze wants to merge 1 commit intofish-shell:masterfrom
xtqqczze wants to merge 1 commit intofish-shell:masterfrom
Conversation
- avoid UB from `usize` → pointer cast - use correct type for `sa_sigaction`
xtqqczze
commented
Feb 26, 2026
| assert_fmt!("%p", 0xDEADBEEF_usize as *const u8 => "0xdeadbeef"); | ||
| assert_fmt!("%p", core::ptr::null::<()>() => "0"); | ||
|
|
||
| let tmp = core::ptr::without_provenance::<()>(0xDEADBEEF); |
Contributor
Author
There was a problem hiding this comment.
This temporary is necessary, otherwise it is error[E0716]: temporary value dropped while borrowed
In theory, we could refactor the assert_fmt macro to handle temporary lifetime extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usize→ pointer castsa_sigactionSee also: rust-lang/libc#4918